Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix preload bootstrap #4862

Merged
merged 2 commits into from
Jul 2, 2019
Merged

Conversation

usingsky
Copy link
Contributor

cannot read property of boostrap in main.js

Fixes #
Close button of flash message does not work.
cffbc237_main.js:204 Uncaught TypeError: element.append(...).alert is not a function at Function.notify.initialize (cffbc237_main.js:204) at HTMLDivElement.<anonymous> (cffbc237_main.js:204) at Function.each (86894786_jquery.js:15) at jQuery.fn.init.each (86894786_jquery.js:5) at cffbc237_main.js:204 at cffbc237_main.js:204

image

Proposed fixes:

preload bootstrap in main.js

Features:

  • includes tests covering changes
  • includes updated documentation
  • includes user-visible changes
  • includes API changes
  • includes bugfix for possible backport

Please [X] all the boxes above that apply

cannot read property of boostrap in main.js
@usingsky
Copy link
Contributor Author

usingsky commented Jun 30, 2019

There is an additional problem.
ckan plugin can not use glyphicon.

condition :
ckan debug : false

Test :
$(“body").html('<span class="glyphicon glyphicon-search" aria-hidden="true"></span>')

Result :
GET http://127.0.0.1:5000/webassets/vendor/bootstrap/fonts/glyphicons-halflings-regular.woff2 net::ERR_ABORTED 404 (NOT FOUND)

@smotornyuk
Copy link
Member

👍

@smotornyuk smotornyuk merged commit b922e6b into ckan:master Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants