Trash page uses action #4906
Open
Trash page uses action #4906
+65
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidread
force-pushed
the
trash-page-uses-action
branch
from
dc3955a
to
10a2dc2
Compare
davidread
force-pushed
the
trash-page-uses-action
branch
3 times, most recently
from
e3a3b1c
to
bc4fee0
Compare
added 2 commits
August 9, 2019 09:43
We add in a call to 'dataset_purge' action to do the purge of the dataset, when previously this done as part of the model.repo.purge_revision() call, but will be deleted soon anyway with the remove-vdm branch.
davidread
force-pushed
the
trash-page-uses-action
branch
from
bc4fee0
to
13c07ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No change to functionality - just a refactor. Adds in a call to 'dataset_purge' action to do the purge of the dataset, when previously this was achieved as part of the model.repo.purge_revision() call, but that revision code will be deleted soon anyway with the remove-vdm branch.
See each revision separately for more clarity.
This refactor is strongly related to #4867. We should probably send out these IResourceController.before_delete events in the logic layer, rather than a view. That could dataset_purge or as I've proposed in #4905 in package_delete.
I've included a test along the lines of the ones added in #4867.
'purge-revisions' also needed deleting, as it was removed from the UI many years ago.
Features:
Please [X] all the boxes above that apply