Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#4914] Update urllib, urllib2 and urlparse usage for Python 3 support #4964

Merged
merged 9 commits into from Sep 12, 2019
Merged

[#4914] Update urllib, urllib2 and urlparse usage for Python 3 support #4964

merged 9 commits into from Sep 12, 2019

Conversation

amercader
Copy link
Member

Fixes #4914

  • Replaces urllib2.open calls with requests
  • Wrapps calls to the old urllib, urllib2 and urlparse modules with the six.moves.urllib.parse wrapper

@amercader amercader removed the WIP label Sep 6, 2019
@amercader
Copy link
Member Author

All green now

@smotornyuk
Copy link
Member

Reviewed and tested locally, so i'm merging it

@smotornyuk smotornyuk merged commit a86242a into master Sep 12, 2019
@smotornyuk smotornyuk deleted the 4914-urllib-python3 branch September 12, 2019 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@smotornyuk smotornyuk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update usage of urllib for Pyhton 3
2 participants
@amercader @smotornyuk