Replace usage of map unsupported on Python 3 #5062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Python 3, map returns a map object not a list. Replaced the occurrences I could find with list comprehensions.
|
@cclauss do you know if there's a flake8 test to catch this type of code? |
|
You did the right thing... manually convert to list comprehensions (or generators where applicable). I do not think flake8 will help you detect these instances but you can try:
|
5 tasks
davidread
pushed a commit
that referenced
this pull request
Nov 8, 2019
Used automated tool:
python-modernize --fix=map .
As suggested: #5062 (comment)
And did a little manual tidying.
|
Thanks for the pointers @cclauss ! |
|
Always happy to help ckan. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Python 3,
mapreturns a map object not a list. Replaced the occurrences I could find with list comprehensions.