Adapt render_snippet exceptions for py3 #5171
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ckan.lib.render_snippet
makes multiple attempts to find a template for rendering and, if failed, throws an exception from the last attempt. Previously it was handled by creating a function-scoped variable outside thetry
block and it was overridden byexcept
block.In python 3, variable that stores caught exception implicitly unset right after
try/catch
so this gives un undefined variable. This PR adapts existing logic so that it works in both versions of python