Fix collapsible menu in mobile view #5448
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last security update of bootstrap exposes a bug in jQuery. it reproducible on master.ckan.org - switch to mobile layout, open dev console, and click on the button that expands header navigation. Header won't expand and you'll see an error in console:
Cannot convert object to primitive value
.This problem can be fixed by upgrading jQuery from 3.5.0 to 3.5.1.
In addition, I've added
package-lock.json
to git, so that we can usenpm ci
instead ofnpm i
and rely on repeatable builds.