Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.8.x: Qld Government core updates: Incorporate delete() and download() into IUploader and ResourceUpload for better cloud integrations #5766

Closed
wants to merge 5 commits into from
Closed

2.8.x: Qld Government core updates: Incorporate delete() and download() into IUploader and ResourceUpload for better cloud integrations #5766

wants to merge 5 commits into from

Commits on Nov 30, 2020

  1. ignore auth checks on loading user details during password resets, ck… 

    …an#5185
    @ThrawnCA @duttonw
    ThrawnCA authored and duttonw committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    437b6bb View commit details
    Browse the repository at this point in the history

  2. [QOL-6619] add error handling for race condition during datastore fil… 

    …e uploads, ckan#3980
    @ThrawnCA @duttonw
    ThrawnCA authored and duttonw committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    99feeaa View commit details
    Browse the repository at this point in the history

  3. [QOL-5909] there are security risks in allowing just anyone to edit u… 

    …sernames (login cookie forgery)

- as sysadmins can already do anything so allow sysadmins to edit usernames
- add nose test to ensure that sysadmins can change account names
- adjust test password handling to match other tests
- redirect after updating username
- include extra environment when redirecting
- use 'submit_and_follow' helper to simplify proper redirection
- adjust test steps to better match successful user edit test
- update context username after updating it in the account
    @ThrawnCA @duttonw
    ThrawnCA authored and duttonw committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    b27a516 View commit details
    Browse the repository at this point in the history

  4. [QOL-7044] replace freshness-based check with a flag 

    - don't update the package modification timestamp if we're only updating the resources
- don't update package modification timestamp more than once every ten seconds, this should reduce lock contention on resource updates
- add comment to explain the delay on updating modification timestamp,
    @ThrawnCA @duttonw
    ThrawnCA authored and duttonw committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    ea3d736 View commit details
    Browse the repository at this point in the history

  5. Incorporate delete() and download() into IUploader, update ResourceUp… 

    …load, Upload with functionality from controller resource_download to allow better cloud integrations

- Add metadata to IUploader interface's
- Add new resource_file_metadata_show get api to surface metadata checks, usage case is archiver or similar verifying files have not change or disappeared
- Hook in delete uploader in resource delete action logic, use upload download logic fully
- Remove unneeded code as its now in the ResourceUpload class, call upload delete when a resource is also deleted
- Uploader and interface update so signature has filename
- Allow filenames to be preserved in uploader
- Add logging if delete method not found
- Need package dict to call uploader correctly
- Add metadata to uploader interface, next step, surface it via package…
    @duttonw
    duttonw committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    9045839 View commit details
    Browse the repository at this point in the history