Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not reactivate a deleted dataset from the UI #607

Merged
merged 1 commit into from
Dec 10, 2013

Conversation

amercader
Copy link
Member

To delete a dataset you need to go the edit form and click on the lower left red button.

After deleting the dataset, if you return to the form to reactivate it the same "Delete" button is shown and there is no "state" field that can be used to set it to active again, so effectively you can't reactivate a deleted dataset.

CKAN master

@amercader
Copy link
Member Author

For reference, this is how it has been dealt with in the harvesting extension for reactivating harvest sources (which are just a dataset type and use a similar form). Basically if the source is deleted the Delete button is not shown and the state select is, so you can at least set it to 'active'.

ckan/ckanext-harvest@2ee3f33

@ghost ghost assigned amercader May 30, 2013
@amercader
Copy link
Member Author

Moving this to 2.2 as it is not urgent at all. Should be really easy to port the fix from ckanex-harvest.

@amercader amercader mentioned this pull request Aug 6, 2013
@ghost ghost assigned johnmartin Aug 6, 2013
@kindly kindly closed this Sep 2, 2013
@amercader
Copy link
Member Author

Reopening as this is still an issue

@amercader amercader reopened this Dec 4, 2013
Currently if a dataset is deleted and users navigate to the edit form,
there is no state field and the delete button is still shown.

After this change, the state dropdown is shown if the dataset state is
not active, and the delete button is not shown.
@ghost ghost assigned johnmartin Dec 9, 2013
@amercader
Copy link
Member Author

@johnmartin assigning this to you as it is a ux thing

johnmartin added a commit that referenced this pull request Dec 10, 2013
Can not reactivate a deleted dataset from the UI
@johnmartin johnmartin merged commit 210ecae into master Dec 10, 2013
@johnmartin johnmartin deleted the 607-allow-reactivating-datasets branch December 10, 2013 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants