Self user details for logged in user #6338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we cannot determine the user details of the user which is logged in without passing the id, so method is modified to fetch the details of the current user if the user is logged in.
shubham-mahajan
changed the title
wardi
reviewed
Aug 25, 2021
| @@ -1386,6 +1388,9 @@ def user_show(context, data_dict): | |||
| ''' | |||
| model = context['model'] | |||
|
|
|||
| if 'user' in context and 'id' not in data_dict: | |||
| data_dict['id'] = context.get('user') | |||
|
|
|||
There was a problem hiding this comment.
The way you've made this change the optional user_obj will never be used.
|
@shubham-mahajan thanks. On second thought while we're here it would be better to completely disable the Also please add a changes file for this new feature so that it appears in the changelog of our next release. |
This param is not needed anymore and may cause issue
|
@wardi Agree with the removal of Updated the code and updated the changes file also for easy changelog handling. |
|
@wardi Anything needed for this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5490
Proposed fixes:
As discussed in #5504 (comment), we are not creating an extra action but adding the functionality in the current
user_showaction. So added the check to validate whether the user is logged in and if logged in return the user details.Features:
Please [X] all the boxes above that apply