Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show function name on job start/finish log messages #6369

Closed
wants to merge 2 commits into from

Conversation

amercader
Copy link
Member

To make it easier to debug background job calls.

Before:

INFO  [ckan.lib.jobs] Worker rq:worker:f0792c8bd67344f288b5704d39c43124 starts job 2baa42e5-4582-4103-92e5-b4a384d0b1da from queue "default"

After:

INFO  [ckan.lib.jobs] Worker rq:worker:f0792c8bd67344f288b5704d39c43124 starts job 2baa42e5-4582-4103-92e5-b4a384d0b1da (process_data_fields) from queue "default"

Features:

  • includes bugfix for possible backport

Please [X] all the boxes above that apply

To make it easier to debug background job calls.

Before:

```
INFO  [ckan.lib.jobs] Worker rq:worker:f0792c8bd67344f288b5704d39c43124 starts job 2baa42e5-4582-4103-92e5-b4a384d0b1da from queue "default"
```

After:

```
INFO  [ckan.lib.jobs] Worker rq:worker:f0792c8bd67344f288b5704d39c43124 starts job 2baa42e5-4582-4103-92e5-b4a384d0b1da (process_data_fields) from queue "default"
```
ckan/lib/jobs.py Outdated Show resolved Hide resolved
@amercader
Copy link
Member Author

Just realized that we have support for a title property that can be passed when calling enqueue_job, but we were just using it when sending the job to the queue, not when starting / finishing it. I've replaced my implementation with this.

@amercader
Copy link
Member Author

Pushed some local changes by mistake see #6387

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants