Skip to content

Add select2 features#6554

Merged
amercader merged 2 commits into
ckan:masterfrom
avdata99:fix_select2_searching_label
Dec 2, 2021
Merged

Add select2 features#6554
amercader merged 2 commits into
ckan:masterfrom
avdata99:fix_select2_searching_label

Conversation

@avdata99
Copy link
Copy Markdown
Member

@avdata99 avdata99 commented Nov 23, 2021

Proposed new features

  • Start using the minimumInputLength select2 option. Useful for heavy API call from an external source
  • Start showing the Searching ... label when select2 have a search in progress. We are (by mistake) wiping results before searching so select2 doesn't know we are searching.
tarra.mp4

Features:

  • includes tests covering changes
  • includes updated documentation
  • includes user-visible changes
  • includes API changes
  • includes bugfix for possible backport

Please [X] all the boxes above that apply

Related to UNHCR#738

@avdata99 avdata99 force-pushed the fix_select2_searching_label branch 3 times, most recently from bfd22d7 to 0e353c9 Compare November 23, 2021 18:25
@avdata99 avdata99 force-pushed the fix_select2_searching_label branch from 0e353c9 to e4b2241 Compare November 23, 2021 18:36
@Zharktas
Copy link
Copy Markdown
Member

We don't want up modify select2.js, it's not our code and the change would be lost when #5697 is done.

@avdata99
Copy link
Copy Markdown
Member Author

We don't want up modify select2.js, it's not our code and the change would be lost when #5697 is done.

I just undo the select2 change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants