Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add select2 features #6554

Merged
merged 2 commits into from Dec 2, 2021
Merged

Conversation

avdata99
Copy link
Member

@avdata99 avdata99 commented Nov 23, 2021

Proposed new features

  • Start using the minimumInputLength select2 option. Useful for heavy API call from an external source
  • Start showing the Searching ... label when select2 have a search in progress. We are (by mistake) wiping results before searching so select2 doesn't know we are searching.
tarra.mp4

Features:

  • includes tests covering changes
  • includes updated documentation
  • includes user-visible changes
  • includes API changes
  • includes bugfix for possible backport

Please [X] all the boxes above that apply

Related to UNHCR#738

@avdata99 avdata99 force-pushed the fix_select2_searching_label branch 3 times, most recently from bfd22d7 to 0e353c9 Compare November 23, 2021 18:25
@Zharktas
Copy link
Member

We don't want up modify select2.js, it's not our code and the change would be lost when #5697 is done.

@avdata99
Copy link
Member Author

We don't want up modify select2.js, it's not our code and the change would be lost when #5697 is done.

I just undo the select2 change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants