member_list is broken #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now returns lists of (id, type, capacity) tuples where type is a string. Previously, type was a Python class object which could not always be serialized to JSON in the API controller.
Allows a proper error to be generated in the API controller instead of just giving a 500 error.
|
@amercader This is another bug to consider for 2.0, cheers. |
| trans = new_authz.roles_trans() | ||
|
|
||
| def translated_capacity(capacity): | ||
| try: | ||
| return trans[capacity] |
There was a problem hiding this comment.
trans doesn't seem to defined anywhere - do we know what this is about it seems wrong to me - can it just be removed?
There was a problem hiding this comment.
@tobes I'm not sure what you mean, roles_trans is in new_authz. Whether we actually need translations of the capacity value is another thing, I'm not sure.
There was a problem hiding this comment.
sorry - just a case of madness ;p
ghost
assigned
amercader
pushed a commit
that referenced
this pull request
Mar 26, 2013
Now returns lists of (id, type, capacity) tuples where type is a string. Previously, type was a Python class object which could not always be serialized to JSON in the API controller.
amercader
pushed a commit
that referenced
this pull request
Mar 26, 2013
Allows a proper error to be generated in the API controller instead of just giving a 500 error.
amercader
pushed a commit
that referenced
this pull request
Mar 26, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing an API request with a valid group ID causes a server 500 error with the message:
Doing an API request with an invalid group ID causes a server 500 error with the message: