-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resource author is always "unknown" #683
Conversation
I'll look into this |
Even if it is a backwards breaking change we sholdn't be allowing the fq parameter to be set through the API as it can lead to privacy issues. We will also enforce that all datasets available through the API are public (as the v3 API does)
If resources don't have authors in the model then I say remove this, but maybe @shevski will have a different opinion |
Looking at the datahub I don't think author was shown on resource pages in 1.8: http://datahub.io/dataset/1855spanishrailways/resource/0a06440b-5ddd-4861-9d78-691049ca4241 |
Happy for us to remove this since there's no way to add Author info in the current interface (& no point duplicating dataset Author). Some resources we harvest in will have authors, but then this will display in show more. We need a way to configure what fields display on different instances though. |
@seanh this is a quicky could you review and push for 2.0 |
what the fuck happened there? this should just be bf31c3a |
Wow this pr has gone nuts |
:) I can kill it - I just branched of the wrong branch - as I said we just need the one commit |
Yeah I will cherry-pick the commit |
Cherry-picked into master and 2.0 |
When you create a dataset can can enter an author for the dataset and it'll be shown on the dataset's page. But if you add a resource to that dataset and then go to the resource's page, it'll say author unknown.
I'm not sure whether this field is supposed to show the dataset's author or if resources have their own authors (when you create or edit a resource, there's no author field to fill in), either way this is a bug.