Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource author is always "unknown" #683

Closed
wants to merge 14 commits into from
Closed

Conversation

tobes
Copy link
Contributor

@tobes tobes commented Mar 25, 2013

When you create a dataset can can enter an author for the dataset and it'll be shown on the dataset's page. But if you add a resource to that dataset and then go to the resource's page, it'll say author unknown.

Screenshot from 2013-03-22 11:16:37

I'm not sure whether this field is supposed to show the dataset's author or if resources have their own authors (when you create or edit a resource, there's no author field to fill in), either way this is a bug.

@ghost ghost assigned tobes Mar 22, 2013
@tobes
Copy link
Contributor

tobes commented Mar 22, 2013

I'll look into this

@tobes
Copy link
Contributor

tobes commented Mar 22, 2013

@seanh @shevski a resource doesn't seem to have an author shall we just remove this?

The other option is the dataset author but that seems wrong

amercader and others added 2 commits March 22, 2013 19:43
Even if it is a backwards breaking change we sholdn't be allowing the fq
parameter to be set through the API as it can lead to privacy issues. We
will also enforce that all datasets available through the API are public
(as the v3 API does)
@tobes
Copy link
Contributor

tobes commented Mar 25, 2013

@seanh @shevski ^ ping

@seanh
Copy link
Contributor Author

seanh commented Mar 25, 2013

If resources don't have authors in the model then I say remove this, but maybe @shevski will have a different opinion

@seanh
Copy link
Contributor Author

seanh commented Mar 25, 2013

Looking at the datahub I don't think author was shown on resource pages in 1.8: http://datahub.io/dataset/1855spanishrailways/resource/0a06440b-5ddd-4861-9d78-691049ca4241

@shevski
Copy link

shevski commented Mar 25, 2013

Happy for us to remove this since there's no way to add Author info in the current interface (& no point duplicating dataset Author).

Some resources we harvest in will have authors, but then this will display in show more. We need a way to configure what fields display on different instances though.

@ghost ghost assigned seanh Mar 25, 2013
@tobes
Copy link
Contributor

tobes commented Mar 25, 2013

@seanh this is a quicky could you review and push for 2.0

@tobes
Copy link
Contributor

tobes commented Mar 25, 2013

what the fuck happened there? this should just be bf31c3a

@seanh
Copy link
Contributor Author

seanh commented Mar 25, 2013

Wow this pr has gone nuts

@tobes
Copy link
Contributor

tobes commented Mar 25, 2013

:) I can kill it - I just branched of the wrong branch - as I said we just need the one commit

@seanh
Copy link
Contributor Author

seanh commented Mar 25, 2013

Yeah I will cherry-pick the commit

tobes added a commit that referenced this pull request Mar 25, 2013
tobes added a commit that referenced this pull request Mar 25, 2013
@seanh
Copy link
Contributor Author

seanh commented Mar 25, 2013

Cherry-picked into master and 2.0

@seanh seanh closed this Mar 25, 2013
@smotornyuk smotornyuk deleted the 683-remove-author-resource branch December 19, 2018 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants