Added validation message when invalid url on dataset search query e.g with comma is given #6939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hussnainwithss
force-pushed
the
6910-url-validation-dataset-sort
branch
from
d2b7eed
to
8a6b2b1
Compare
|
Can you report this problem to the user in a more gentle way? For example, if an invalid Solr query is used, the user still sees the search page with a message, that error happened. I think that the wrong sorting order should produce either the same or even more clear error message. |
…. with comma is given fixed linting & type issues handles error in a more gentle way
hussnainwithss
force-pushed
the
6910-url-validation-dataset-sort
branch
from
6b26a0f
to
48bbe0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6910
Proposed fixes:
http://localhost:8080/dataset/?q=&sort=title_string+asc,Features:
Please [X] all the boxes above that apply