Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prepare_dataset_blueprint: support dataset type #7032

Merged
merged 3 commits into from
Sep 8, 2022
Merged

prepare_dataset_blueprint: support dataset type #7032

merged 3 commits into from
Sep 8, 2022

Conversation

wardi
Copy link
Contributor

@wardi wardi commented Aug 23, 2022

Fixes #7031

Proposed fixes:

Delay registering dataset and resource blueprints until after plugins have had a chance to override them

Features:

  • includes tests covering changes
  • includes updated documentation
  • includes user-visible changes
  • includes API changes
  • includes bugfix for possible backport

@wardi wardi changed the title [#7031] prepare_dataset_blueprint: support dataset type prepare_dataset_blueprint: support dataset type Aug 23, 2022
@wardi
Copy link
Contributor Author

wardi commented Aug 25, 2022

@smotornyuk added the type ignore, do you mind reviewing this one too?

@smotornyuk smotornyuk self-assigned this Aug 30, 2022
@smotornyuk smotornyuk merged commit a94ce98 into master Sep 8, 2022
@smotornyuk smotornyuk deleted the 7031-dataset-type-blueprint branch September 8, 2022 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@smotornyuk smotornyuk

Labels
zBackport 2.9.8
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

prepare_dataset_blueprint: support dataset type
3 participants
@wardi @amercader @smotornyuk