[7028]Lock down cookie based authentication on API endpoints [PART ONE] #7058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amercader
reviewed
Sep 7, 2022
There was a problem hiding this comment.
@TomeCirun see comment, also:
- The
recline_viewis not working, we need to send the CSRF token somewhere in this file (probably here) - I think that the Datatables view is working fine (there is JS error that seems unrelated) but please check all functionalities in case I missed a call
- Please replicate all changes made in the
publicfolder in thepublic-bs3one
|
Thanks @TomeCirun ! I added the missing recline_view bit in f7ac8b8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7028
Proposed fixes:
Features:
Please [X] all the boxes above that apply