Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to display site description when logo defined #7094

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Deep-NEC
Copy link

Fixes #6111

Proposed fixes:

This fix will allow to use ckan site description even when site logo is defined

Features:

  • includes tests covering changes
  • includes updated documentation
  • includes user-visible changes
  • includes API changes
  • includes bugfix for possible backport

Please [X] all the boxes above that apply

@Deep-NEC
Copy link
Author

Hi @kowh-ai I have investigated ci/circleci: test-python-3 failure, it is failed due to def test_tag_line. In this function it is defined to test the description/tag-line only when no logo and in this PR the fix is to display description/tag-line even when logo is defined. Hence we need to modify the testcase def test_tag_line according to this PR. Please confirm my understanding.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ckan.site_description isn't used
2 participants