[#621] Move extras_validation into __before #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where creating a new resource would crash in validation if there was a custom field (using convert_to/from_extras) with a name that sorted after extras validation alphabetically. Fixes #621.
ghost
assigned
added 3 commits
April 10, 2013 16:12
Fix a crash when generating a 'duplicate extras key' error. To trigger the crash, post a dataset dict to package_create() containing two extras dicts with the same key. There is no test for this yet.
This code path was not covered by the tests.
…s_validation_into___before
|
@kindly I see what went wrong. The code path that generates the duplicate extras key error was not covered by the core tests, not the example idatasetform plugin. I've fixed it now and added tests so if the tests pass on travis you can review again |
| errors[key].append(_('Duplicate key "%s"') % extras_keys[0]) | ||
| key_ = ('extras_validation',) | ||
| assert key_ not in errors | ||
| errors[key_] = _('Duplicate key "%s"') % extras_keys[0] |
There was a problem hiding this comment.
The errors normally come back as a list I thought. so [_('Duplicate key "%s"') % extras_keys[0]]
This makes it consistent with other errors that CKAN returns.
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kindly this is a resubmit of #685 as requested