Clean group extra revisions before purging a group #7317
+79
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avdata99
force-pushed
the
clean_group_extra_revisions
branch
from
a3b05c1
to
572c804
Compare
avdata99
force-pushed
the
clean_group_extra_revisions
branch
2 times, most recently
from
be43008
to
08e77e7
Compare
avdata99
force-pushed
the
clean_group_extra_revisions
branch
from
08e77e7
to
07b8a9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/okfn/ckanext-unhcr/issues/728
Proposed fixes:
It's not clear to me if Group extra revisions continues working in CKAN.
It's also not clear if they are some kind of cascade deletion policy running.
In case this don't work anymore but I have old records for revision, a severe error could happen.
This PR ensures that we remove group extra revision while we purge a group.
Features:
Please [X] all the boxes above that apply