Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lenient datastore API: accept "" instead of null #7359

Merged
merged 2 commits into from
Mar 9, 2023
Merged

lenient datastore API: accept "" instead of null #7359

merged 2 commits into from
Mar 9, 2023

Conversation

wardi
Copy link
Contributor

@wardi wardi commented Jan 25, 2023 •
edited

Fixes #7358

Proposed fixes:

convert empty string values to null for non-text fields

Features:

  • includes tests covering changes
  • includes updated documentation
  • includes user-visible changes
  • includes API changes
  • includes bugfix for possible backport

@wardi
Copy link
Contributor Author

wardi commented Feb 16, 2023

@amercader this PR is ready for review

@amercader amercader merged commit fe879f9 into master Mar 9, 2023
@amercader amercader deleted the 7358-lenient-upsert branch March 9, 2023 11:29
@wardi wardi mentioned this pull request Oct 30, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@amercader amercader

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lenient datastore_upsert
2 participants
@wardi @amercader