New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config from env vars must be normalized #7502
Conversation
Example of normalizing a single option: from ckan.common import config_declaration as cd
# get the Option object that contains normalization rules
option = cd['ckan.devserver.port']
# normalize value
assert option.normalize('5000') == 5000
# note: invalid values are not normalized and
# do not produce any errors in this way
assert option.normalize('sf') == 'sf' |
I think this is ready for review @smotornyuk |
We decided in the tech meeting to stop giving precedente to |
@avdata99, would you happen to have time to update this PR on Monday? We will make a patch release soon, and it would be nice to include this fix. If not, I'll add a couple of commits to your PR. |
@smotornyuk, sorry. No, I can't update this PR today. Please feel free to update the branch |
Done |
CONFIG_FROM_ENV_VARS
takes precedence over config file and extensions but those settings are not normalizedThis is a work in progress.
Is this a bug? Am I missing something?
Features:
Please [X] all the boxes above that apply