Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make vdm 0.11 a PyPI package dependency #764

Merged
merged 1 commit into from
May 31, 2013
Merged

Conversation

amercader
Copy link
Member

I just had to install CKAN in an offline environment. It would have helped if the CKAN dependencies were all non-editable ie. published as packages on PyPI (e.g. like this).

vdm is the only editable dependency left because vdm==0.11 is not published on PyPI (see okfn/vdm#5 ).

@tobes
Copy link
Contributor

tobes commented Apr 16, 2013

@kindly were you looking to remove vdm?

@stefanw
Copy link
Contributor Author

stefanw commented Apr 22, 2013

I had another look into this and the difference between the released vdm-0.10 and non-released vdm-0.11 is only logging and error messages.

@kindly @rgrp Please publish vdm-0.11 to PyPI or fix the dependency in CKAN to vdm-0.10.

I'm doing deployment consulting for an "offline" environment where I need to bring packages with me and therefore need published packages instead of editable resources as dependencies.

Removing editable resources will also make installs faster as packages can be cached locally and can be put on their own pip-mirror etc.

@tobes
Copy link
Contributor

tobes commented Apr 22, 2013

@stefanw rgrp no longer does ckan development I realise that vdm may be owned by him

@stefanw
Copy link
Contributor Author

stefanw commented Apr 22, 2013

@tobes I know, but @rgrp was involved in vdm and likely is the one person who can push a new release to PyPI.

Makes easier to install CKAN on offline environments
@stefanw
Copy link
Contributor Author

stefanw commented May 16, 2013

I'm disappointed to see that this is commit is not part of the 2.0 release. This will make deploying a stable 2.0 much more difficult.

@ghost ghost assigned nigelbabu May 16, 2013
@tobes
Copy link
Contributor

tobes commented May 16, 2013

@amercader where is this at? do we need a pull request? maybe we should backport to 2.0.1?

@amercader
Copy link
Member

When this was proposed, 2.0 was in the pre-release freeze and changes in requirements are generally not accepted then. The issue was flagged as 2.1 and no objections were raised to it.
I understand that this is not a requirement change per se so I'm happy to backport it to 2.0.1.
@stefanw that will mean that the package install will then include this change.

@ghost ghost assigned domoritz May 30, 2013
domoritz added a commit that referenced this pull request May 31, 2013
Make vdm 0.11 a PyPI package dependency
@domoritz domoritz merged commit 9d4dde9 into master May 31, 2013
@tobes tobes deleted the 764-vdm-from-pypi branch May 31, 2013 10:24
amercader added a commit that referenced this pull request May 31, 2013
Makes easier to install CKAN on offline environments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants