-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
datastore_upsert, datastore_create error fixes #7697
Conversation
datastore_upsert method=insert: prevent 500 on invalid data datastore_create datastore_create: invalid data errors now reported against records value (not "message")
@smotornyuk not sure what's going on with the type check, there's no "cast" at the line in the error and it wasn't failing one commit ago |
The master branch is fixed. The issue was caused by two PRs with conflicting changes(one removes the I suspect now you need to merge the master into the current branch because GH action does not see changes from the master if I re-run the type-check job manually from the GitHub interface. |
@smotornyuk well, we're getting a different error now. That counts as progress right? 😄 |
Another PR, but this time it was created 5 months ago and it passed type-check. Since then we've updated dependencies, which slightly change the type signature of the version parser. And because of this after the merge(which was completely legit, as all checks were green) we've got a problem. The only way to avoid such a problem is to review and merge everything immediately:) I merged the master into the current branch and now it's green, so I won't test my luck and merge this PR |
Fixes #7683
Proposed fixes:
report postgres record errors consistently against records parameter
datastore_upsert method=insert: prevent 500 on invalid data datastore_create
datastore_create: invalid data errors now reported against records value (not "message")
Features: