Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datastore_upsert, datastore_create error fixes #7697

Merged
merged 8 commits into from
Jul 25, 2023

Conversation

wardi
Copy link
Contributor

@wardi wardi commented Jul 7, 2023

Fixes #7683

Proposed fixes:

report postgres record errors consistently against records parameter

datastore_upsert method=insert: prevent 500 on invalid data datastore_create
datastore_create: invalid data errors now reported against records value (not "message")

Features:

  • includes tests covering changes
  • includes updated documentation
  • includes user-visible changes
  • includes API changes
  • includes bugfix for possible backport

wardi added 5 commits July 6, 2023 22:27
datastore_upsert method=insert: prevent 500 on invalid data datastore_create
datastore_create: invalid data errors now reported against records value (not "message")
@wardi
Copy link
Contributor Author

wardi commented Jul 11, 2023

@smotornyuk not sure what's going on with the type check, there's no "cast" at the line in the error and it wasn't failing one commit ago

@smotornyuk
Copy link
Member

The master branch is fixed. The issue was caused by two PRs with conflicting changes(one removes the cast import because it's not used inside a module, and another calls cast) which were merged approximately at the same time.

I suspect now you need to merge the master into the current branch because GH action does not see changes from the master if I re-run the type-check job manually from the GitHub interface.

@wardi
Copy link
Contributor Author

wardi commented Jul 20, 2023

@smotornyuk well, we're getting a different error now. That counts as progress right? 😄

@smotornyuk
Copy link
Member

Another PR, but this time it was created 5 months ago and it passed type-check. Since then we've updated dependencies, which slightly change the type signature of the version parser. And because of this after the merge(which was completely legit, as all checks were green) we've got a problem. The only way to avoid such a problem is to review and merge everything immediately:)

I merged the master into the current branch and now it's green, so I won't test my luck and merge this PR

@smotornyuk smotornyuk merged commit 38cc9bd into master Jul 25, 2023
8 checks passed
@smotornyuk smotornyuk deleted the 7683-invalid-error-invalid branch July 25, 2023 12:13
@wardi wardi mentioned this pull request Oct 30, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

datastore: InvalidDataError is an invalid data error
2 participants