Fix Possible Member Duplication #7804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Made `member_create` action method behave like `group_member_save` dictize method.
- Added change log file. - Added type ignore for incomplete SQLAlchemy types.
|
Due to changes to CircleCI, someone with write permissions to this repo and who is added as a member to the CircleCI project will have to initialize the build/pipeline |
amercader
reviewed
Sep 21, 2023
Co-authored-by: Adrià Mercader <amercadero@gmail.com>
|
@amercader committed you suggestions. I am not part of the Circle CI project, nor have write perms on the ckan org or repos. So the Circle CI tests won't get triggered from my commits |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(logic): member create behave like member save;
member_createaction method behave likegroup_member_savedictize method.Fixes
There is a possible scenario in which a member can get "duplicated". This happens if the member is deleted, and then re-added and the generated primary ID of the member happens to get selected before the old deleted member from the database table.
The
group_member_savedictization method already handles this scenario. So this is just aligning themember_createlogic action method to behave similarly to that.Features:
Please [X] all the boxes above that apply