Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Missing Confirm Action Views/Templates #7813

Merged

Conversation

JVickery-TBS
Copy link
Contributor

feat(templates): added missing confirm delete views;

  • Added GET view to delete package collaborator.
  • Added GET view to delete user.
  • Fixes to canceling group member delete confirmation.

Fixes

There were a couple missing pages for confirming the delete action of users and dataset collaborators. There was also an issue with group member delete cancel button not working.

Features:

  • includes tests covering changes
  • includes updated documentation
  • includes user-visible changes
  • includes API changes
  • includes bugfix for possible backport

Please [X] all the boxes above that apply

- Added GET view to delete package collaborator.
- Added GET view to delete user.
- Fixes to canceling group member delete confirmation.
- Added changelog file.
- Added `str` type return for dataset collaborator delete.
@smotornyuk smotornyuk merged commit 440a9be into ckan:master Oct 12, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants