Backport PR 7839 to v2.9 (DataStore Dump Streaming) #7899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Backport code from PR 7839 for v2.9.
- Backport code from PR 7839 for v2.9.
|
Sorry @JVickery-TBS, there are some failures in the datastore |
- Run tests.
- Fixed str/bytes issues with python2 and python3 for datastore dump writers.
|
@amercader sorry! Okay I had to fix up the string vs bytes stuff, namely with the BOMs and the XML writer. The tests should pass now. And I manually tested locally on a CKAN 2.9 python2 install, and a python3 install. And the code works in both. |
- PEP8 syntax fixes.
- PEP8 syntax fixes.
|
@amercader the only test not passing is |
|
@JVickery-TBS try building them yourself with |
|
Thanks @JVickery-TBS ,I'll take care of the docs failures, these are unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport(datastore): 7839 for 2.9;
#7839
CC: @amercader