Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Views Create CLI Sub-Command Fixes #7944

Merged
merged 2 commits into from Nov 29, 2023
Merged

Views Create CLI Sub-Command Fixes #7944

merged 2 commits into from Nov 29, 2023

Conversation

JVickery-TBS
Copy link
Contributor

fix(cli): minor fixes to views create;

  • Fixed no context in package_search.
  • Fixed return set for default filters.

Proposed fixes:

The cli sub-command of ckan views create does not give the package_search action call a context, which can cause it to return no results.

Also the default filters for the query were not getting set.

Features:

  • includes tests covering changes
  • includes updated documentation
  • includes user-visible changes
  • includes API changes
  • includes bugfix for possible backport

Please [X] all the boxes above that apply

@JVickery-TBS
fix(cli): minor fixes to views create;
89fec74 
- Fixed no context in `package_search`.
- Fixed return set for default filters.
@JVickery-TBS
fix(dev): changelog and typing;
bc08b65 
- Added change log file.
- Fixed typing issue.
@amercader amercader merged commit b5d51a6 into ckan:master Nov 29, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@smotornyuk smotornyuk

Labels
zBackport 2.10.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JVickery-TBS @amercader @smotornyuk