[#7945] Translate aria-label attributes #7947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #7945 For HTML templates we just wrap the value in the `{{ _() }}` function so they get extracted. For markup that is generated from JS modules, we need to find the attribute and replace the value with the translated string. "Close" was not extracted up until now, so one this is merged we'll need to run `extract_messages` so it goes to the pot file > Transifex > po files (in 2.10.2 and 2.11.0)
pdelboca
reviewed
Nov 29, 2023
There was a problem hiding this comment.
@amercader looks good! Check my comment, probably in that context we cannot call to this._()
|
Thanks @pdelboca , should be all good now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7945
For HTML templates we just wrap the value in the
{{ _() }}function so they get extracted. For markup that is generated from JS modules, we need to find the attribute and replace the value with the translated string. "Close" was not extracted up until now, so once this is merged we'll need to runextract_messagesso it goes to the pot file > Transifex > po files (in 2.10.2 and 2.11.0)