Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass package type through to resource creation activity item #8050

Merged

Conversation

ThrawnCA
Copy link
Contributor

@ThrawnCA ThrawnCA commented Feb 2, 2024

Fixes #8034

Proposed fixes:

Pass the package dict through from change_item.html to new_resource.html so we can extract the correct package type if needed.

This is better than a simple fallback to 'dataset' since it lets us preserve custom package types.

However, I'm unsure of the best target branch for this.

Features:

  • includes tests covering changes
  • includes updated documentation
  • includes user-visible changes
  • includes API changes
  • includes bugfix for possible backport

Please [X] all the boxes above that apply

@ThrawnCA
Copy link
Contributor Author

ThrawnCA commented Feb 2, 2024

The typecheck failure is not coming from this change.

@wardi wardi self-assigned this Feb 6, 2024
@wardi
Copy link
Contributor

wardi commented Feb 6, 2024

Please make the PR against master, we typically backport to release branches (dev-v2.10 etc.) after merging. The 2.10 and other "bare" version number branches are only used for generating friendly version numbers for our docs

@ThrawnCA ThrawnCA changed the base branch from 2.10 to master February 6, 2024 22:17
@ThrawnCA ThrawnCA force-pushed the github-8034-fix-package-creation-activity-stream branch from 7d39ebf to fdba0bc Compare February 6, 2024 22:19
@ThrawnCA
Copy link
Contributor Author

ThrawnCA commented Feb 6, 2024

Please make the PR against master

Done.

@wardi wardi merged commit 132b96e into ckan:master Feb 23, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Activity Stream Changes link
3 participants