[superseded ignore] 500 on non-ascii url

[tobes]

Hi.

If i point my webbrowser to eg.
http://datahub.io/r%C3%A4ksm%C3%B6rg%C3%A5s

Instead of giving me a 404 it gives me a 500 and sends a stacktrace to the configured admin.

[tobes]

@amercader I've assigned this to you in case you feel we should take it for 2.0 - It feels like it'd be no harm to take it

[amercader]

If I'm not mistaken, your fix only silences the exception but does not fix the fact that we can not use unicode names on templates. Something like this would perhaps be better:

diff --git a/ckan/lib/render.py b/ckan/lib/render.py
index e0ef0a9..3ad60ae 100644
--- a/ckan/lib/render.py
+++ b/ckan/lib/render.py
@@ -10,7 +10,7 @@ def find_template(template_name):
     returns the full path is it exists. '''
     template_paths = config['pylons.app_globals'].template_paths
     for path in template_paths:
-        if os.path.exists(os.path.join(path, template_name)):
+        if os.path.exists(os.path.join(path, template_name.encode('utf-8'))):
             return os.path.join(path, template_name)

 def template_type(template_path):
diff --git a/ckan/lib/base.py b/ckan/lib/base.py
index 0fd783c..40cdd5d 100644
--- a/ckan/lib/base.py
+++ b/ckan/lib/base.py
@@ -130,7 +130,7 @@ def render(template_name, extra_vars=None, cache_key=None, cache_type=None,
             return render_jinja2(template_name, globs)

         # Genshi templates
-        template = globs['app_globals'].genshi_loader.load(template_name,
+        template = globs['app_globals'].genshi_loader.load(template_name.encode('utf-8'),
                                                            cls=loader_class)
         stream = template.generate(**globs)

This way you get 404 and can have templates named ckan/templates/räksmörgås.html

[tobes]

@amercader yeah that is a much better solution. do you want me to make it into a pull request? If you want to do it feel free and assign me and I'll merge it

[amercader]

@tobes, thanks a pr with my patch would be great

[amercader]

Merged into 2.0 and 1.8.1