Increase read bytes from file to detect xlsx mimetypes correctly #8088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XLSX files technically are just zipped files and magic detects them as
applcation/zip, internet sources say that reading about 2000 bytes should be enough to detect them asapplication/vnd.openxmlformats-officedocument.spreadsheetml.sheetWe had a custom object type where the files were handled with standard uploader and stumbled upon this.
This should be backported to 2.9 and 2.10 as well.
Features:
Please [X] all the boxes above that apply