allow sysadmins to edit usernames, #4193 #8122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThrawnCA
force-pushed
the
github-4193-username-editing
branch
from
333ff9f
to
ad8b767
Compare
- Username modification is a potential security risk, but sysadmins can access any account anyway
ThrawnCA
force-pushed
the
github-4193-username-editing
branch
from
ad8b767
to
869d404
Compare
|
This looks good @ThrawnCA , but the test failed. Can you check? |
I'll look into it, but I'm not sure why the test is failing when I know this code works in production. |
…3-username-editing
- Pass API token via 'headers' parameter instead of 'extra_environ'
ThrawnCA
force-pushed
the
github-4193-username-editing
branch
from
655e224
to
4f04000
Compare
|
Thanks @ThrawnCA |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion on #4193 identified editing usernames as a potential security hole, allowing takeover of another account in specific situations. However, sysadmins already have more privileges than this security weakness could grant. Thus, there is no additional risk in permitting sysadmins to edit other accounts.
Proposed fixes:
Allow sysadmins to edit usernames.
Features:
Please [X] all the boxes above that apply