Requirements April 2024 (JS) #8157
Conversation
Moved the cleanup code to a fixture
The new Cypress version renames a lot of files but the suite itself hasn't been changed
Remove completely our own version parsing and rely on the one from
packaging. Older versions of packaging used to be more lenient with our
release tags ("ckan-x.y.z") but now they will fail. We need to remove
the `ckan-` bit before parsing.
When upgrading cypress to >= 12.0.0 many of our tests started failing. That's because starting from Cypress 12.0.0 the `testIsolation` option is enabled by default: https://docs.cypress.io/guides/references/migration-guide#Test-Isolation As our old Pylons server side tests, it looks like the frontend ones were written in a way where tests are not isolated and rely on previous state. To get the tests working again we are passing `{testIsolation: false}` to each test spec, but as stated in the docs above this is not recommended and we should rewrite our tests so they can be run independently.
The updated accessibility tests were flagging issues with the `link-in-text-block` check, that ensures that links can be suficiently distinct from surrounding text. Rather than changing the color, this adds an underline to links **within paragraphs**, following the available guidelines: https://accessibilityinsights.io/info-examples/web/needs-review/link-in-text-block/
|
One thing the updated accessibility tests flagged was issues with the https://accessibilityinsights.io/info-examples/web/needs-review/link-in-text-block/ Before: After:
If accepted, this should be flagged in the changelog |
|
@smotornyuk One thing I'm confused about are the typing errors. I've updated pyright to 1.1.357 but quickly reverted it as there were about 90 new failures (that will be better fixed separately). But it seems that even sticking with the previous version I still get some new failures. Any idea? |
|
Found a solution - run NPM's dependency resolver incorrectly resolved versions of packages used by pyright and cypres and, as result, pyright was downgraded to an older version. |
|
@smotornyuk thanks, done now. Typing error unrelated, see #8196 (comment) |
Follow up from #8146, that should be merged first
This upgrades the frontend requirements to the latest version.
Several issues found:
Build failing due to Bootstrap changes(fixed, but upgrade abandoned)I reverted the upgrade from Bootstrap 5.1 to 5.3 because there were a lot of visual changes and minor breakages that would be better fixed in a separate PR, possibly as part of the frontend refresh that @thegostev is leading:
Before (current)
After