-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli profile improvements #8223
cli profile improvements #8223
Conversation
@smotornyuk my pyright errors don't look like the ones from CI. It is using the pyproject.toml settings so there must be something else I'm missing, here are some of the errors I see locally (I don't see the ones reported above):
Version:
|
@wardi, the currently used version of pyright is v1.1.339. Most likely you did one of the following:
Yes, the newer the better, but it detects more problems and I need to create a separate PR with pyright upgrade. For now try the following: npm ci
npx pyright On your branch it gives me only two errors:
For these two errors, add a If you are interested in what caused these 2 errors:
To fix the problem we can either make a PR to typeshed, wait for the release and upgrade pyright. It will take too much time so alternatives are using from cProfile import Profile as _Profile
from typing import Any
class Profile(_Profile):
getstats: Any |
Sorry, just noticed, that I attached a link to the latest version of typeshed with |
Fixes #
Proposed fixes:
ckan profile profile /url
should be spelledckan profile /url
Features: