Skip to content

Commit

Permalink
[#60] Fix wrong redirects for localized URLs
Browse files Browse the repository at this point in the history
Parts of code passed the result of `url_for` to `redirect_to`, which
resulted in the localization code being added twice to the URL.
  • Loading branch information
torfsen committed Sep 27, 2017
1 parent 467d7e2 commit 31de27c
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions ckanext/pages/controller.py
Expand Up @@ -98,7 +98,7 @@ def org_edit(self, id, page=None, data=None, errors=None, error_summary=None):
error_summary = e.error_summary
return self.org_edit(id, '/' + page, data,
errors, error_summary)
p.toolkit.redirect_to(p.toolkit.url_for('organization_pages', id=id, page='/' + _page['name']))
p.toolkit.redirect_to('organization_pages', id=id, page='/' + _page['name'])

if not data:
data = _page
Expand Down Expand Up @@ -175,7 +175,7 @@ def group_edit(self, id, page=None, data=None, errors=None, error_summary=None):
error_summary = e.error_summary
return self.group_edit(id, '/' + page, data,
errors, error_summary)
p.toolkit.redirect_to(p.toolkit.url_for('group_pages', id=id, page='/' + _page['name']))
p.toolkit.redirect_to('group_pages', id=id, page='/' + _page['name'])

if not data:
data = _page
Expand Down Expand Up @@ -345,8 +345,7 @@ def pages_edit(self, page=None, data=None, errors=None, error_summary=None, page
error_summary = e.error_summary
return self.pages_edit('/' + page, data,
errors, error_summary, page_type=page_type)
p.toolkit.redirect_to(p.toolkit.url_for('%s_show' % page_type,
page='/' + _page['name']))
p.toolkit.redirect_to('%s_show' % page_type, page='/' + _page['name'])

try:
p.toolkit.check_access('ckanext_pages_update', {'user': p.toolkit.c.user or p.toolkit.c.author})
Expand Down

0 comments on commit 31de27c

Please sign in to comment.