Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable file downloads to go through a proxy if needed #127

Merged
merged 2 commits into from
Oct 28, 2021

Conversation

ThrawnCA
Copy link
Collaborator

@ThrawnCA ThrawnCA commented Jan 28, 2021

Optionally use the ckan.download_proxy config value as a proxy when downloading files.

This allows the site owner to manage cases where file access depends on network location, or requires authentication.

@ThrawnCA
Copy link
Collaborator Author

@amercader Is there anything further that needs to be done before this is suitable to be merged? It's quite a small change, and entirely backwards compatible.

@amercader amercader merged commit ef30095 into ckan:master Oct 28, 2021
@amercader
Copy link
Member

Thanks @ThrawnCA this is long overdue. I've merged your PRs in ckanext-xloader, datapusher and ckanext-validation (ckanext-archiver is pending: ckan/ckanext-archiver#78). Is there anything else I missed?

The one thing we would need is a PR is the main ckan repo that:

As this is backwards compatible we can backport it to previous CKAN versions so it appears in their docs.

Many thanks for your work and your patience

@ThrawnCA
Copy link
Collaborator Author

ThrawnCA commented Nov 3, 2021

@amercader I wasn't sure how to name the 'changes' file, since there isn't a core issue for this, but I've raised a pull request.

@duttonw duttonw deleted the enable-download-proxy branch November 10, 2023 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants