Limit duplicate builds #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since GitHub Actions workflows are triggered on every push, triggering on pull request is usually redundant. The exception is when pull requests are opened across repositories. However, it should be sufficient to trigger a build on pull request if the target branch is 'master'. This will ensure that changes can't be merged into the master branch without being tested first, but will not always trigger extra builds for pull requests internal to a repo.
|
Thanks @ThrawnCA ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't force an extra GitHub Actions workflow execution on pull request unless the target branch is 'master'.
This will reduce the number of duplicate executions (since we already trigger on 'push'), while still ensuring that cross-repo pull requests to 'master' will be tested.