feat(core): add transaction builder for signing transactions with mul… #362
Conversation
…tiple private keys
| import { blake2b, hexToBytes, bytesToHex, PERSONAL } from '@nervosnetwork/ckb-sdk-utils' | ||
| import Address from './address' | ||
|
|
||
| export default (addrObj: Address, transactionHash: string, witness: string = '') => { |
There was a problem hiding this comment.
signWitness is a action, so maybe it's not appropriate for file name.
There was a problem hiding this comment.
It's better to keep the name the same as the function exported by default in js.
| s.update(hexToBytes(transactionHash)) | ||
| s.update(witnessBytes) | ||
| const message = `0x${s.digest('hex')}` | ||
| const data = [...hexToBytes(addrObj.signRecoverable(message)), ...witnessBytes] |
There was a problem hiding this comment.
Why signRecoverable function is in Address module ?
There was a problem hiding this comment.
In fact, the Address class derives from the ECPairs class, which is used to generate key pairs, thus the address object is able to sign messages.
There was a problem hiding this comment.
OK. I just think Address and ECPairs are different modules, and signRecoverable can be in ECPairs but not Address.
There was a problem hiding this comment.
Agree. I have been wanting to propose changing Address's base type for long time. It's not great to let developer know that address is an ECPairs.
There was a problem hiding this comment.
Please plan this in another feature branch.
| } | ||
| } | ||
|
|
||
| public updateTransactionHash = () => { |
There was a problem hiding this comment.
When and where updateTransactionHash function will be called? I don't catch it and I think it could be private.
There was a problem hiding this comment.
It will be called automatically on calling signInput if the builder.hash is empty. But it should be able to update the hash manually when the raw transaction is updated and the hash is calculated already.
There was a problem hiding this comment.
OK. I think sometimes we support more interfaces maybe not a good thing.
…tiple private keys