-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement rpc calculate_dao_maximum_withdraw in sdk #578
Merged
Keith-CY
merged 8 commits into
ckb-js:develop
from
yanguoyu:calculate-dao-maximum-withdraw
Mar 2, 2022
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
9ffb550
implement rpc calculate_dao_maximum_withdraw in sdk
yanguoyu 94a34a5
move data calc into utils
yanguoyu 62feec6
add unit test
yanguoyu 7e5a8fc
move extract DAO to utils and add test
yanguoyu ed53a49
add test for calculateDaoMaximumWithdraw
yanguoyu b8da57f
fix
yanguoyu cbe3765
delete ;
yanguoyu 8cd4f45
change calculateMaximumWithdraw return value to hex string
yanguoyu File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
occupied capacity
is dynamic according to10200000000
is just for the default lock in the example.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to ckb-explorer, the
occupied capacity
is determined bywithdraw cell
, when thewithdrawal
doesn't occur, we can assume thecell
won't change and usedeposit cell
instead ofwithdraw cell
.