Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement resource binding component #100

Merged
merged 29 commits into from
Jan 18, 2023
Merged

feat: implement resource binding component #100

merged 29 commits into from
Jan 18, 2023

Conversation

Daryl-L
Copy link
Contributor

@Daryl-L Daryl-L commented Jan 8, 2023

  1. Message implementation
  2. Manager implementation

Related to issue #96

@Daryl-L Daryl-L mentioned this pull request Jan 8, 2023
Closed
3 tasks
@Keith-CY Keith-CY mentioned this pull request Jan 11, 2023
Closed
Keith-CY
Keith-CY reviewed Jan 11, 2023
View reviewed changes
packages/models/src/resource-binding/types.ts Outdated Show resolved Hide resolved
packages/models/src/resource-binding/utils.ts Outdated Show resolved Hide resolved
packages/models/src/resource-binding/utils.ts Outdated Show resolved Hide resolved
packages/models/src/resource-binding/interface.ts Outdated Show resolved Hide resolved
packages/models/src/resource-binding/manager.ts Outdated Show resolved Hide resolved
packages/models/src/resource-binding/manager.ts Show resolved Hide resolved
@Daryl-L Daryl-L force-pushed the feature/resource_binding branch 3 times, most recently from f518199 to 8b45f89 Compare January 11, 2023 15:30
@Daryl-L Daryl-L force-pushed the feature/resource_binding branch 2 times, most recently from 8cb2bdf to 9bd2cac Compare January 15, 2023 15:20
@Daryl-L Daryl-L force-pushed the feature/resource_binding branch 3 times, most recently from 74699a5 to 801dc5d Compare January 17, 2023 04:36
@Daryl-L Daryl-L self-assigned this Jan 17, 2023
@Daryl-L Daryl-L force-pushed the feature/resource_binding branch 2 times, most recently from d35d74f to 3638bf7 Compare January 17, 2023 09:44
@Keith-CY
Copy link
Member

There're 3 approvals and no more unresolved conversations, could we merge this PR?

@Daryl-L
feat(resource binding): add resource binding manager
e2d8baa 
1. resource binding manager and test
2. listener
3. fix some code lint error
@Daryl-L
feat(resource-binding): listen to top header and fetch the blocks fro…
c313d97 
…m current block
@Daryl-L
test(resource binding): add test for the block arrived twice
d739218
@Daryl-L
feat(resource-binding): pattern set by developer when register
f50481d
@Daryl-L
test(resource-binding): test input outpoint not registered
db5d05d
@Daryl-L
test(resource-binding): add test for revoke registry which not exists
8d7e0b6
@Daryl-L
feat(resource-binding): change remove cell from pr ckb-js#99
e25cebb
@Daryl-L
style(resource-binding): rename names
ad3d91f
@Daryl-L
feat(resource-binding): use import type to instead import only
8ccce72
@Daryl-L
fix(resource-bingding): use BI to format HexString when assemble the …
6512f83 
…outpoint
@Daryl-L
fix(io): need main for package entry
914bb3b
@Daryl-L
refactor(resource-binding): change @kuai/io to @ckb-js/kuai-io
0d34736
@Daryl-L
fix(io): export need "default" option
5842177
@Daryl-L
fix(resource-binding): change name for the test of function "outPoint…
23544e6 
…ToOutPointString"
@Daryl-L
feat(resource-binding): batch to send change cell information
a0e4b74
@Daryl-L
style(resource-binding): code style changed
a5f25f5
@Daryl-L
feat(resource-binding): change update_cell to update_cells
b12a177
@Daryl-L
feat(resource-bingding): don't use BI
c4fc6f6
@Daryl-L
style(resource-binding): code style changed
410be89
@Daryl-L
style(resource-binding): change name "filterOutputs" to "mapOutputs"
8eef230
@Daryl-L
style(resource-binding): change code style to camel
ac1475b
@Daryl-L
style(resource-binding): add comment
023a5c0
@Daryl-L
test(resource-binding): test batch update and remove cells
e5cdeb3
@Daryl-L
test(resource-binding): add tests
3e3d1a0 
1. add tests for redis queue
2. change payload structure
@Daryl-L Daryl-L merged commit 2345cfc into ckb-js:develop Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanguoyu yanguoyu yanguoyu approved these changes

@zhengjianhui zhengjianhui zhengjianhui approved these changes

@Keith-CY Keith-CY Keith-CY approved these changes

@PainterPuppets PainterPuppets Awaiting requested review from PainterPuppets

Assignees

@Daryl-L Daryl-L

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Daryl-L @Keith-CY @yanguoyu @zhengjianhui