Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(@kuai/io): support params #103

Merged
merged 1 commit into from
Feb 2, 2023
Merged

feat(@kuai/io): support params #103

merged 1 commit into from
Feb 2, 2023

Conversation

PainterPuppets
Copy link
Contributor

  • KuaiRouter support parse params payload
  • KoaRouterAdapter support pass body & query payload

@Keith-CY
Copy link
Member

Conflicted, and please rebase on the develop branch to make the CI pass

Keith-CY
Keith-CY reviewed Jan 18, 2023
View reviewed changes
package-lock.json Show resolved Hide resolved
packages/io/src/adapter.ts Outdated Show resolved Hide resolved
packages/io/src/types/index.ts Outdated Show resolved Hide resolved
packages/io/src/types/index.ts Outdated Show resolved Hide resolved
packages/io/src/types/index.ts Outdated Show resolved Hide resolved
packages/io/src/router.ts Outdated Show resolved Hide resolved
yanguoyu
yanguoyu reviewed Jan 27, 2023
View reviewed changes
packages/io/src/types/index.ts Outdated Show resolved Hide resolved
packages/io/src/types/index.ts Show resolved Hide resolved
@Keith-CY
Copy link
Member

Keith-CY commented Feb 1, 2023

Any update on this issue?

@PainterPuppets
Copy link
Contributor Author

Any update on this issue?

There is a type of problem is still being solved, should be almost done

@PainterPuppets PainterPuppets force-pushed the router_support_params branch 2 times, most recently from f40636f to 78a9453 Compare February 2, 2023 03:07
Keith-CY
Keith-CY reviewed Feb 2, 2023
View reviewed changes
packages/io/src/adapter.ts Outdated Show resolved Hide resolved
packages/io/src/types/index.ts Outdated Show resolved Hide resolved
packages/io/src/types/index.ts Show resolved Hide resolved
@PainterPuppets PainterPuppets force-pushed the router_support_params branch 2 times, most recently from fd16964 to 0460455 Compare February 2, 2023 05:23
@Keith-CY
Copy link
Member

Keith-CY commented Feb 2, 2023

One more approval is required to merge

@PainterPuppets PainterPuppets merged commit 396e121 into develop Feb 2, 2023
@PainterPuppets PainterPuppets deleted the router_support_params branch February 2, 2023 07:09
@PainterPuppets PainterPuppets restored the router_support_params branch February 3, 2023 15:21
@Keith-CY Keith-CY deleted the router_support_params branch July 21, 2023 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Daryl-L Daryl-L Daryl-L approved these changes

@Keith-CY Keith-CY Keith-CY approved these changes

@zhengjianhui zhengjianhui Awaiting requested review from zhengjianhui

@yanguoyu yanguoyu Awaiting requested review from yanguoyu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@PainterPuppets @Keith-CY @Daryl-L @yanguoyu