Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/resource binding init sample #138

Merged
merged 8 commits into from
Feb 13, 2023
Merged

Feature/resource binding init sample #138

merged 8 commits into from
Feb 13, 2023

Conversation

Daryl-L
Copy link
Contributor

@Daryl-L Daryl-L commented Feb 10, 2023 •
edited
Loading

  1. add implementation of chain source
  2. add bootstrap of resource binding

Keith-CY
Keith-CY reviewed Feb 10, 2023
View reviewed changes
packages/samples/mvp-dapp/src/chain-source.ts Outdated Show resolved Hide resolved
packages/samples/mvp-dapp/src/chain-source.ts Outdated Show resolved Hide resolved
packages/samples/mvp-dapp/kuai.config.js Outdated Show resolved Hide resolved
@Keith-CY
Copy link
Member

Conflicted

@Keith-CY
Copy link
Member

Conflicted

Conflicts should be resolved by Daryl-L#1

@Keith-CY
Copy link
Member

I've tried running on this branch and find the mvp-dapp doesn't work

  1. Path of resource actor should be the root, / or undefined are both fine, but explicit '' makes it empty. ref: https://github.com/ckb-js/kuai/pull/138/files#diff-38d98fc038c1a05b8da2d5c2c9e0e9db88c3ed2eb646dbe4334e9f861eaa865cR15
  2. After setting the path of resource actor to /, the app still breaks down

@Daryl-L Daryl-L force-pushed the feature/resource-binding-init-sample branch from 41fdcf9 to 98bbf9a Compare February 12, 2023 15:58
@Daryl-L
Copy link
Contributor Author

Daryl-L commented Feb 12, 2023 •
edited
Loading

I've tried running on this branch and find the mvp-dapp doesn't work

  1. Path of resource actor should be the root, / or undefined are both fine, but explicit '' makes it empty. ref: https://github.com/ckb-js/kuai/pull/138/files#diff-38d98fc038c1a05b8da2d5c2c9e0e9db88c3ed2eb646dbe4334e9f861eaa865cR15
  2. After setting the path of resource actor to /, the app still breaks down

resolved d607c34

@Daryl-L Daryl-L force-pushed the feature/resource-binding-init-sample branch from 6f2f919 to 2abbcad Compare February 13, 2023 01:15
@Daryl-L Daryl-L force-pushed the feature/resource-binding-init-sample branch from 2abbcad to d607c34 Compare February 13, 2023 01:15
@Keith-CY Keith-CY merged commit b95b584 into ckb-js:develop Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keith-CY Keith-CY Keith-CY left review comments

@yanguoyu yanguoyu yanguoyu approved these changes

@zhengjianhui zhengjianhui zhengjianhui approved these changes

@PainterPuppets PainterPuppets Awaiting requested review from PainterPuppets

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Daryl-L @Keith-CY @yanguoyu @zhengjianhui