Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix configuration #25

Merged
merged 1 commit into from
Nov 15, 2022
Merged

fix: fix configuration #25

merged 1 commit into from
Nov 15, 2022

Conversation

Keith-CY
Copy link
Member

  1. rename "kuaiproject" to "kuai"
  2. use npm by default cuz yarn is not configured in lerna.json
  3. fix inconsistent versions among packages and project
  4. set node.js@18 required cuz 18 is LTS and 16 will be deprecated in a year
  5. rename the "CI" action to "Test" which is more explicit

@Keith-CY
fix: fix configuration
f6f11a9 
1. rename "kuaiproject" to "kuai"
2. use `npm` by default cuz `yarn` is not configured in `lerna.json`
3. fix inconsistent versions among packages and project
4. set node.js@18 required cuz 18 is LTS and 16 will be deprecated in a year
5. rename the "CI" action to "Test" which is more explicit
@Keith-CY
Copy link
Member Author

Since we're using lerna to manage packages, the dependencies and versions should be delegated to lerna by lerna add and lerna version

@Keith-CY Keith-CY merged commit 536c082 into main Nov 15, 2022
@Keith-CY Keith-CY deleted the fix-config branch November 15, 2022 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanguoyu yanguoyu yanguoyu approved these changes

@PainterPuppets PainterPuppets PainterPuppets approved these changes

@felicityin felicityin Awaiting requested review from felicityin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Keith-CY @yanguoyu @PainterPuppets