Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add docker-node packege & integrate node cli #37

Merged
merged 1 commit into from
Dec 19, 2022
Merged

feat: add docker-node packege & integrate node cli #37

merged 1 commit into from
Dec 19, 2022

Conversation

PainterPuppets
Copy link
Contributor

integrate kuai/cli & kuai/core

  • add docker-node packege
  • add builtin node task
  • node task test

resolve: #8

image

image

@PainterPuppets PainterPuppets changed the base branch from develop to integrate_cli November 24, 2022 00:02
yanguoyu
yanguoyu reviewed Nov 25, 2022
View reviewed changes
packages/docker-node/src/docker-manager.ts Outdated Show resolved Hide resolved
packages/docker-node/src/docker-manager.ts Outdated Show resolved Hide resolved
packages/docker-node/src/docker-manager.ts Outdated Show resolved Hide resolved
Keith-CY
Keith-CY reviewed Nov 25, 2022
View reviewed changes
packages/cli/__tests__/index.ts Outdated Show resolved Hide resolved
packages/cli/__tests__/index.ts Outdated Show resolved Hide resolved
packages/core/src/type/runtime.ts Outdated Show resolved Hide resolved
packages/docker-node/ckb/dev.toml Outdated Show resolved Hide resolved
packages/docker-node/package.json Outdated Show resolved Hide resolved
packages/docker-node/src/docker-manager.ts Outdated Show resolved Hide resolved
packages/docker-node/src/docker-manager.ts Outdated Show resolved Hide resolved
packages/docker-node/src/docker-manager.ts Outdated Show resolved Hide resolved
packages/docker-node/src/docker-manager.ts Outdated Show resolved Hide resolved
packages/docker-node/src/docker-manager.ts Outdated Show resolved Hide resolved
@PainterPuppets PainterPuppets force-pushed the integrate_cli branch 2 times, most recently from 53c851c to 5e1cf8a Compare November 29, 2022 09:38
Base automatically changed from integrate_cli to develop November 29, 2022 09:53
@Keith-CY Keith-CY added this to the 2022/11/24 - 2022/12/01 milestone Nov 30, 2022
@PainterPuppets PainterPuppets force-pushed the integrate_node branch 2 times, most recently from 5d70356 to da3014b Compare December 1, 2022 02:26
Keith-CY
Keith-CY reviewed Dec 3, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
packages/cli/src/main.ts Outdated Show resolved Hide resolved
packages/core/src/builtin-tasks/node.ts Show resolved Hide resolved
packages/core/src/builtin-tasks/node.ts Show resolved Hide resolved
packages/docker-node/src/docker-manager.ts Outdated Show resolved Hide resolved
packages/docker-node/src/errors.ts Outdated Show resolved Hide resolved
@PainterPuppets PainterPuppets changed the base branch from develop to support_variadic_param December 7, 2022 22:46
Keith-CY
Keith-CY reviewed Dec 9, 2022
View reviewed changes
packages/docker-node/tsconfig.json Outdated Show resolved Hide resolved
packages/core/package.json Outdated Show resolved Hide resolved
Base automatically changed from support_variadic_param to develop December 10, 2022 17:51
@Keith-CY
Copy link
Member

Any update on this PR?

@Keith-CY Keith-CY merged commit 706e673 into develop Dec 19, 2022
@Keith-CY Keith-CY deleted the integrate_node branch December 19, 2022 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keith-CY Keith-CY Keith-CY approved these changes

@yanguoyu yanguoyu yanguoyu approved these changes

@felicityin felicityin Awaiting requested review from felicityin

Assignees
No one assigned
Labels
None yet
Projects
CKB JS Backlog
Archived in project
Milestone
2022/11/24 - 2022/12/01
Development

Successfully merging this pull request may close these issues.

launch a local network for testing
3 participants
@PainterPuppets @Keith-CY @yanguoyu