Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mvp dapp inproper wrapper of response #378

Merged
merged 2 commits into from
Jul 20, 2023
Merged

fix: mvp dapp inproper wrapper of response #378

merged 2 commits into from
Jul 20, 2023

Conversation

PainterPuppets
Copy link
Contributor

fix: #325

@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2023 •
edited
Loading

Codecov Report

Merging #378 (215829b) into develop (bc71654) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #378   +/-   ##
========================================
  Coverage    62.39%   62.39%           
========================================
  Files           94       94           
  Lines         3101     3101           
  Branches       688      688           
========================================
  Hits          1935     1935           
  Misses        1057     1057           
  Partials       109      109
Impacted Files Coverage Δ
packages/samples/mvp-dapp/src/app.controller.ts 39.62% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc71654...215829b. Read the comment docs.

@Keith-CY Keith-CY enabled auto-merge July 20, 2023 06:24
@Keith-CY Keith-CY disabled auto-merge July 20, 2023 07:53
@Keith-CY Keith-CY merged commit 9a4c044 into develop Jul 20, 2023
2 checks passed
@Keith-CY Keith-CY deleted the fix_mvp_dapp_inproper_response_wrapper branch July 20, 2023 07:53
This was referenced Jul 21, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Daryl-L Daryl-L Daryl-L approved these changes

@Keith-CY Keith-CY Keith-CY approved these changes

@yanguoyu yanguoyu yanguoyu approved these changes

@zhengjianhui zhengjianhui Awaiting requested review from zhengjianhui

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inproper wrapper of response
5 participants
@PainterPuppets @codecov-commenter @Daryl-L @Keith-CY @yanguoyu