Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: init project #9

Merged
merged 6 commits into from
Nov 15, 2022
Merged

chore: init project #9

merged 6 commits into from
Nov 15, 2022

Conversation

homura
Copy link
Contributor

@homura homura commented Oct 18, 2022

Description

Init Kuai project, with a @kuaiproject/cli package for demo

git clone https://github.com/homura/kuai.git
cd kuai
yarn
yarn build
# workspace symlink
yarn install --force
yarn kuai node --port 8114

@homura homura marked this pull request as draft October 18, 2022 01:44
@homura homura force-pushed the init-project branch 4 times, most recently from 0342404 to 027828f Compare October 18, 2022 03:01
@homura homura marked this pull request as ready for review October 18, 2022 04:46
Development.md Outdated Show resolved Hide resolved
packages/cli/package.json Outdated Show resolved Hide resolved
Co-authored-by: Chen Yu <keithwhisper@gmail.com>
@Keith-CY
Copy link
Member

I'm not sure if it's a good time to start coding because we don't have production and architecture design.

Besides, I think running a node via task would be better than embedding it in the cli module

.eslintignore Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
.prettierrc Outdated Show resolved Hide resolved
@homura
Copy link
Contributor Author

homura commented Oct 18, 2022

I'm not sure if it's a good time to start coding because we don't have production and architecture design

this PR just init the project structure, and, I think that we probably already have some more deterministic things that we can start coding, such as

  • fetch a ckb container from DockerHub
  • a ckb.toml for launching local network

Besides, I think running a node via task would be better than embedding it in the cli module

We do need to design Task first, the cli package for this PR is for demo only, not directly for production

Task or Command are actually quite similar, commander's Command is more popular than Hardhat's Task (according to the number of npm downloads), so I'll use it as an example

Signed-off-by: homura <homura.dev@gmail.com>
@Keith-CY
Copy link
Member

There're two conventions we'd better follow

  1. pin dependencies for clarity and certainty;
  2. sign every commit for security.

Signed-off-by: homura <homura.dev@gmail.com>
homura and others added 2 commits October 25, 2022 15:05
Co-authored-by: Chen Yu <keithwhisper@gmail.com>
Signed-off-by: homura <homura.dev@gmail.com>
@yanguoyu
Copy link
Contributor

Need to add README.md for users.

@Keith-CY Keith-CY merged commit 7707364 into ckb-js:main Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants