fix: connect status is always connected #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #157 +/- ##
=======================================
Coverage 87.25% 87.25%
=======================================
Files 48 48
Lines 816 816
Branches 97 97
=======================================
Hits 712 712
Misses 21 21
Partials 83 83
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
IronLu233
commented
Mar 28, 2023
IronLu233
force-pushed
the
connected-status
branch
from
f8bdea0
to
17f8b04
Compare
homura
reviewed
Mar 28, 2023
IronLu233
force-pushed
the
connected-status
branch
from
b530c4c
to
57f513f
Compare
IronLu233
force-pushed
the
connected-status
branch
from
57f513f
to
5e2d396
Compare
homura
changed the title
homura
approved these changes
Mar 28, 2023
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed
closes #149
Motivation
In previous version, the connect status indicator can not react when tab changes.
This PR fix it.
Change Type
Indicate the type of change your pull request is:
documentationpatchminormajor