Custom data support for widget commands

[zipp3r]

Just pass the second editor.execCommand argument to Widget instance initialization

[Reinmar]

Hey. It's a great idea. Just two things:

1. It would be safer to pass the widget data as part of another object: editor.execCommand( 'someWidget', { startupData: { ... } } ). This will allow passing more properties in the future without making a non-backward compatible change. E.g. one may want to be able to say if a newly created widget should be focused.
2. This feature will need at least one test (e.g. right after this one: https://github.com/ckeditor/ckeditor-dev/blob/master/tests/plugins/widget/definition.js#L402). You can read more about CKEditor testing environment here: http://docs.ckeditor.com/#!/guide/dev_tests

[zipp3r]

@Reinmar, hi, and thanks for the advices!

[teameh]

Nice, mine was almost identical. #152 I looked for PR's but did not find this one apparently. @Reinmar are you asking me or @zipp3r to edit our pull request and implement your suggested way of handeling the data?

Btw I think mine and @zipp3r's solution would not be a complete implementation.

If we want the match the docs and add commandData as a param to the command function:

// You can execute an automatically defined command to
// insert a new simplebox widget or edit the one currently focused.
editor.execCommand( 'simplebox', commandData);

We should als implement the edit function around https://github.com/ckeditor/ckeditor-dev/blob/master/plugins/widget/plugin.js#L1041 to let the function work with focussed widgets.

[Reinmar]

I made a small cleanup (code style, variable name), added API docs (pity that commands are not documented :() and merged changes to the major branch. See 2dbc4f3.

We should also implement the edit function

I think it's ok the way you guys proposed it. It makes sense that this data is passed only to the constructor, especially that the property is called startupData. It does not have to affect the edit() call, because instead of executing the command, one could simply execute the setData() method and, if needed, then the command. Basically, the widget creation scenario is the most complex one there, so it makes sense to cover only it, because in the other scenarios a developer can simply call the right method directly.

Thanks for the great contribution, guys!