Changed tables to be HTML5 compliant #270
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ded to normalize color attr from RGB to HEX in IE. Conflicts: core/style.js
…g directly into scrollIntoParent method.
|
Hi @wporter82, thanks for the contribution. Could you rebase your code onto the latest major / master branch? This PR contains a bit of noise and we'd like it to be sorted out so that we can review it - thanks! |
|
Hi, It's been a while since we last heard from you. We're closing this issue for now. Still, feel free provide us requested feedback, so that we can reopen this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a requirement to use tables and found that css libraries typically will reset the td tag to no padding. In order to make this possible, I had to update the tables plugin to use HTML5 compliant code, ie: styles instead of attributes.
When editing an existing table with this update, it will convert it if table properties are viewed. This should keep from breaking sites that upgrade.