Ckeditor: Add a new event that is triggered when the template is clicked. #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ked. * Pass the template in its entirety so that all of its properties can be accessed. * Use case: * I needed to store some server side information in the template and inject that information in a separate field when the template is injected into the editor.
|
Any feedback on this one? Thanks. |
|
Hello @scottalan, thanks for the PR! This pull request is missing tests, see our Contributing Code guide for more details. Please, provide a unit and manual test for this, so that we can verify it. If you need any help or assistance with it, feel free to ask. |
|
@f1ames Yep, sorry about that. We needed the fix quick and I will admit I didn't read that bit of documentation. I'll look into bender when I have a free moment and provide a test. Thank you. |
|
Hi, It's been a while since we last heard from you. We're closing this issue for now. Feel free to still provide us requested feedback, so that we can reopen this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
information in a separate field when the template is injected into the editor.
If you feel I made a poor choice in naming conventions please comment and I'll be more than happy to modify them.